Review Request 120500: Remove VLC workaround

Kai Uwe Broulik kde at privat.broulik.de
Sun Oct 5 13:16:50 UTC 2014



> On Okt. 5, 2014, 1:11 nachm., Martin Klapetek wrote:
> > > VLC no longer seems to be exposing multiple mpris interfaces
> > 
> > Kubuntu 14.04, VLC 2.1.4 and I still see two mpris interfaces. I'll try the patch out in the evening.

Kubuntu 14.10, VLC 2.2.0-pre2 here.

Maybe they fixed that for the 2.2 version, so probably for master then instead of Plasma/5.1


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120500/#review67957
-----------------------------------------------------------


On Okt. 5, 2014, 1:09 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120500/
> -----------------------------------------------------------
> 
> (Updated Okt. 5, 2014, 1:09 nachm.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Klapetek.
> 
> 
> Bugs: 332584
>     https://bugs.kde.org/show_bug.cgi?id=332584
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> commit a998595ff7fa0751c894987e2a046ef685169ef5
> Author: Kai Uwe Broulik <kde at privat.broulik.de>
> Date:   Sun Oct 5 15:03:56 2014 +0200
> 
>     Revert "Fix mediacontroller showing twice for VLC"
>     
>     VLC no longer seems to be exposing multiple mpris interfaces, and also the
>     media controller should only be shown once regardless of this.
>     This fixes mediacontroller not working when Plasma starts after VLC (crash recovery)
>     
>     CCBUG: 332584
>     
>     This reverts commit f18ef033332d27a060e5db37f99ce359796f4d61.
> 
> 
> Diffs
> -----
> 
>   dataengines/mpris2/mpris2engine.cpp 42ca565 
> 
> Diff: https://git.reviewboard.kde.org/r/120500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141005/a92e9af9/attachment.html>


More information about the Plasma-devel mailing list