Review Request 121206: Port savesystem to KDevPlatform and qml

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121206/#review70881
-----------------------------------------------------------



plasmate/plugins/savesystemview/git.h
<https://git.reviewboard.kde.org/r/121206/#comment49550>

    Have you seen we already have a BranchesModel? It can be useful to you, in this case. Also there's a VcsEventsModel, IIRC.



plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml
<https://git.reviewboard.kde.org/r/121206/#comment49551>

    i18n()?



plasmate/plugins/savesystemview/savesystemviewplugin.cpp
<https://git.reviewboard.kde.org/r/121206/#comment49552>

    Wouldn't it be better to use QQuickWidget?



plasmate/plugins/savesystemview/savesystemviewplugin.cpp
<https://git.reviewboard.kde.org/r/121206/#comment49553>

    You're showing it at the bottom here, it's good to have a good default, people usually don't move these around.


- Aleix Pol Gonzalez


On Nov. 22, 2014, 3:46 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121206/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 3:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> This patch is a port of the savesystem to KDevPlatform and qml.
> 
> 
> Savesystem is using KDevPlatform's code for handling the git and
> the ui is rewritten in qml.
> 
> I have attached an image of the new savesystem
> 
> 
> Diffs
> -----
> 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION 
>   plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION 
>   plasmate/plugins/CMakeLists.txt 410080b 
>   plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/savesystemview/Messages.sh PRE-CREATION 
>   plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION 
>   plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/git.h PRE-CREATION 
>   plasmate/plugins/savesystemview/git.cpp PRE-CREATION 
>   plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION 
>   plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION 
>   plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121206/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> savesystem in kdevelop
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141124/aaad2d0f/attachment-0001.html>