<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121206/">https://git.reviewboard.kde.org/r/121206/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121206/diff/1/?file=329439#file329439line60" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/plugins/savesystemview/git.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QStringList</span> <span class="nf">branches</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have you seen we already have a BranchesModel? It can be useful to you, in this case. Also there's a VcsEventsModel, IIRC.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121206/diff/1/?file=329453#file329453line46" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">text:</span> <span class="s2">"Cancel"</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i18n()?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121206/diff/1/?file=329461#file329461line44" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/plugins/savesystemview/savesystemviewplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QWidget</span><span class="o">::</span><span class="n">createWindowContainer</span><span class="p">(</span><span class="n">view</span><span class="p">,</span> <span class="n">parent</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wouldn't it be better to use QQuickWidget?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121206/diff/1/?file=329461#file329461line48" style="color: black; font-weight: bold; text-decoration: underline;">plasmate/plugins/savesystemview/savesystemviewplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">Qt</span><span class="o">::</span><span class="n">LeftDockWidgetArea</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You're showing it at the bottom here, it's good to have a good default, people usually don't move these around.</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 22nd, 2014, 3:46 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2014, 3:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is a port of the savesystem to KDevPlatform and qml.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Savesystem is using KDevPlatform's code for handling the git and
the ui is rewritten in qml.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have attached an image of the new savesystem</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/View.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/Home.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/savesystemview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/savesystemview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/savesystemviewplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/savesystemviewplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/CMakeLists.txt <span style="color: grey">(410080b)</span></li>
<li>plasmate/plugins/savesystemview/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/commitsmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/commitsmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/git.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/git.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/kdevsavesystemview.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121206/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png">savesystem in kdevelop</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>