Review Request 121162: Some ideas for the image wallpaper

Marco Martin notmart at gmail.com
Mon Nov 24 19:16:19 UTC 2014



> On Nov. 17, 2014, 9:37 p.m., Kai Uwe Broulik wrote:
> > wallpapers/image/imagepackage/contents/ui/main.qml, line 167
> > <https://git.reviewboard.kde.org/r/121162/diff/1/?file=328929#file328929line167>
> >
> >     What is the clipping for? I thought clipping was evil :) Or does that actually improve things because we probably don't render outside the visible screen? Dunno.

yeah, should be completely useless


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70539
-----------------------------------------------------------


On Nov. 17, 2014, 9:34 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 9:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> -------
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141124/ff880031/attachment.html>


More information about the Plasma-devel mailing list