Review Request 121162: Some ideas for the image wallpaper

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121162/#review70539
-----------------------------------------------------------



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49360>

    I don't know if readonly properties have any performance benefit but they certainly prevent you from accidentally changing things.



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49361>

    I was hoping for it to wait until the image was fully loaded to start the fade but that didn't help. Unfortunately QML has no "please do this after rendering the current frame has finished" method.



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49362>

    I didn't see any flickering.



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49363>

    Don't needlessly draw a root Rectangle that isn't visible in the first place.
    There's still yet another item below of the wallpaper according to qsg overdraw.



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49365>

    What is the clipping for? I thought clipping was evil :) Or does that actually improve things because we probably don't render outside the visible screen? Dunno.



wallpapers/image/imagepackage/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/121162/#comment49364>

    Heh.


- Kai Uwe Broulik


On Nov. 17, 2014, 9:34 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121162/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 9:34 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is just a bunch of stuff I played around with I'd like to get comments on
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml d81bd29 
> 
> Diff: https://git.reviewboard.kde.org/r/121162/diff/
> 
> 
> Testing
> -------
> 
> QSG_VISUALIZE=overdraw and a bit of playing around
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141117/ead38254/attachment.html>