Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation

[Bhushan Shah]

> On Nov. 22, 2014, 12:24 a.m., Aleix Pol Gonzalez wrote:
> > src/runnercontext.cpp, line 200
> > <https://git.reviewboard.kde.org/r/121201/diff/1/?file=329397#file329397line200>
> >
> >     It should possibly be using the new QUrl::fromUserInput()...
> >     
> >     http://doc-snapshot.qt-project.org/qt5-5.4/qurl.html#fromUserInput-2

Umm it is introduced in Qt 5.4, so question is can krunner depend upon 5.4 being framework?


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121201/#review70752
-----------------------------------------------------------


On Nov. 21, 2014, 11:40 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121201/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 11:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 340140
>     https://bugs.kde.org/show_bug.cgi?id=340140
> 
> 
> Repository: krunner
> 
> 
> Description
> -------
> 
> One can also uses a decimal point in a calculator.
> 
> 
> Diffs
> -----
> 
>   autotests/runnercontexttest.cpp ba5f6a1 
>   src/runnercontext.cpp 2d6177d 
> 
> Diff: https://git.reviewboard.kde.org/r/121201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141122/bdfba889/attachment.html>