Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Nov 21 18:54:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121201/#review70752
-----------------------------------------------------------
src/runnercontext.cpp
<https://git.reviewboard.kde.org/r/121201/#comment49483>
It should possibly be using the new QUrl::fromUserInput()...
http://doc-snapshot.qt-project.org/qt5-5.4/qurl.html#fromUserInput-2
- Aleix Pol Gonzalez
On Nov. 21, 2014, 6:10 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121201/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 6:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 340140
> https://bugs.kde.org/show_bug.cgi?id=340140
>
>
> Repository: krunner
>
>
> Description
> -------
>
> One can also uses a decimal point in a calculator.
>
>
> Diffs
> -----
>
> autotests/runnercontexttest.cpp ba5f6a1
> src/runnercontext.cpp 2d6177d
>
> Diff: https://git.reviewboard.kde.org/r/121201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141121/f4ff7f88/attachment.html>
More information about the Plasma-devel
mailing list