Review Request 121113: Use Qt's method of blocking for component completion rather than our own

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121113/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 10:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
-------

We had a while loop which processed all application events whilst we
were in the middle of creating objects. This leads to weird bugs, and
workarounds in ShellCorona.

Qt's methods forceCompletion does not seem to have the same problems and
works just as well.


Diffs
-----

  src/kdeclarative/qmlobject.cpp 029edaf 

Diff: https://git.reviewboard.kde.org/r/121113/diff/


Testing
-------

Ran plasmashell with many panels filled with applets

Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141119/95ac12a1/attachment.html>