Review Request 121114: Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by QPluginLoader.

Jeremy Whiting jpwhiting at kde.org
Thu Nov 13 20:26:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121114/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

Add Q_PLUGIN_METADATA so the attica_kde.so plugin can be loaded by QPluginLoader.


Diffs
-----

  attica-kde/kdeplugin/kdeplatformdependent.h 69883dba4d24567a4787ebc8217beab0723891ea 

Diff: https://git.reviewboard.kde.org/r/121114/diff/


Testing
-------

Before this attica would try to load the plugin (if it was installed in the right place, I've another attica patch to fix that) but failed because QPluginLoader::instance() would return null without this.

Now it works (with my attica patch)


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141113/5f5feaf9/attachment.html>


More information about the Plasma-devel mailing list