Review Request 121148: Make WallpaperInterface use the suggested async object loading API

Aleix Pol Gonzalez aleixpol at kde.org
Tue Nov 18 22:04:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121148/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 10:04 p.m.)


Review request for Plasma.


Changes
-------

update according to the changes in the kdeclarative side of the patch.


Repository: plasma-framework


Description
-------

Just asks QmlObject to create an object and waits for QmlObject::finished signal to acquire it.


Diffs (updated)
-----

  src/scriptengines/qml/plasmoid/wallpaperinterface.h 20c811f 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 36e34b5 

Diff: https://git.reviewboard.kde.org/r/121148/diff/


Testing
-------

plasmashell seems to load fine.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/2265b099/attachment-0001.html>


More information about the Plasma-devel mailing list