Review Request 121148: Make WallpaperInterface use the suggested async object loading API

Sebastian Kügler sebas at kde.org
Tue Nov 18 11:52:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121148/#review70580
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 17, 2014, 11:10 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121148/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 11:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Just asks QmlObject to create an object and waits for QmlObject::finished signal to acquire it.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.h 20c811f 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 36e34b5 
> 
> Diff: https://git.reviewboard.kde.org/r/121148/diff/
> 
> 
> Testing
> -------
> 
> plasmashell seems to load fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141118/3146b705/attachment.html>


More information about the Plasma-devel mailing list