Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121004/#review69924
-----------------------------------------------------------


for the record: there was no change in KWin. I just had a look at the Alt+F4 handling (for those interested: kwin/useractions.cpp, Workspace::slotWindowClose) and desktop windows are ignored:
(active_client && !(active_client->isDesktop() || active_client->isDock()))

- Martin Gräßlin


On Nov. 5, 2014, 6:21 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121004/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 6:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338360
>     https://bugs.kde.org/show_bug.cgi?id=338360
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove uneeded code to stop alt+f4 killing the window
> 
> This fixes ksmserver not being able to logout or shutdown correctly as
> it was unable to kill Plasma.
> 
> Tests showed that pressing alt+f4 no longer kills the window anyway
> (possibly a change in kwin or Qt?)
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp adf405f 
> 
> Diff: https://git.reviewboard.kde.org/r/121004/diff/
> 
> 
> Testing
> -------
> 
> Previously I could not log out with:
> qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout 0 0 0
> 
> with this patch I can.
> 
> Pressed alt+f4 when desktop + panels were the only window. Nothing seemed to happen.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141106/31574d04/attachment.html>