Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121004/#review69906
-----------------------------------------------------------


[18:19] <bshah> d__ed: IIRC Alt+F4 code was added due to bug I reported.. but it seems this is not case now... tried your patch and Alt+F4 is not killing plasmashell
[18:19] <bshah> so "Ship it!" too
[18:19] <d__ed> bshah: you're still on Qt5.3?

- David Edmundson


On Nov. 5, 2014, 5:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121004/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 5:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338360
>     https://bugs.kde.org/show_bug.cgi?id=338360
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove uneeded code to stop alt+f4 killing the window
> 
> This fixes ksmserver not being able to logout or shutdown correctly as
> it was unable to kill Plasma.
> 
> Tests showed that pressing alt+f4 no longer kills the window anyway
> (possibly a change in kwin or Qt?)
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp adf405f 
> 
> Diff: https://git.reviewboard.kde.org/r/121004/diff/
> 
> 
> Testing
> -------
> 
> Previously I could not log out with:
> qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout 0 0 0
> 
> with this patch I can.
> 
> Pressed alt+f4 when desktop + panels were the only window. Nothing seemed to happen.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141105/2e627759/attachment.html>