Review Request 120954: drop libkonq_export for internal libkonq copy

Harald Sitter sitter at kde.org
Mon Nov 3 09:09:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120954/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 9:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
-------

as suggested by David Faure to fix the build fail introduced in b29f85d
since the internal libkonq does not have an export header


Diffs
-----

  containments/folder/plugin/internallibkonq/konq_copytomenu.h a830c5d8b6d19ae05636919acbb8b1c47e0bd524 
  containments/folder/plugin/internallibkonq/konq_dndpopupmenuplugin.h f92cce9d8dee65bdbad4fe7ef26768e081f97ef4 
  containments/folder/plugin/internallibkonq/konq_operations.h 1b36516d8c1993a65e90949187985722e95f6b3c 
  containments/folder/plugin/internallibkonq/konq_popupmenu.h 56fb765e7367469f253a1444fff2009f41520439 
  containments/folder/plugin/internallibkonq/konq_popupmenuplugin.h a4e33f5a02838d63db016571d440ca92282dc8ed 

Diff: https://git.reviewboard.kde.org/r/120954/diff/


Testing
-------

built plasma-desktop in an environment without libkonq_export.h


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/bdfe6d03/attachment.html>


More information about the Plasma-devel mailing list