Review Request 120577: Remove shutdown option from lockscreen's look and feel

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120577/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 8:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Aleix Pol Gonzalez.


Bugs: 339453
    https://bugs.kde.org/show_bug.cgi?id=339453


Repository: plasma-workspace


Description
-------

Logging out from the locked screen is impossible. Logging out means
interaction with the session due to the session manager. The session
manager asks all applications to quit and applications are allowed to
ask for example saving changes. The session manager stopps the
logout in this case and asks the window manager to focus this window
and the session manager will only continue the logout once the
application resolved the situation. At any time in this process the
user is still able to abort the logout!

Switching to the application which needs interaction is impossible,
though as the screen is still locked. The result is a seemingly
frozen system as the logout cannot continue and there is no indication
what is going on.

Of course the lock screen cannot unlock the session for the logout as
that would circumvent the security. If the lock screen would unlock
one would just have to click the button and abort the logout really
fast to have the system unlocked. So this is clearly not an option.

The result is: we cannot implement this functionality in a working
and secure manner, so it's better to remove it.


Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.cpp fd1d20b824dd7781cb5c2e96895694f290a46877 
  lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d 
  ksmserver/screenlocker/greeter/greeterapp.h f3033c701fb3c3ce5fa8f12f58ee8c6af739444b 

Diff: https://git.reviewboard.kde.org/r/120577/diff/


Testing
-------

run kscreenlocker_greeter --testing and locked the screen - button is gone.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/5f386940/attachment-0001.html>