Review Request 118413: Put the settings views in a ScrollView

Aleix Pol Gonzalez aleixpol at kde.org
Fri May 30 10:50:51 UTC 2014



> On May 30, 2014, 10:42 a.m., David Edmundson wrote:
> > desktoppackage/contents/configuration/AppletConfiguration.qml, line 224
> > <https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line224>
> >
> >     is large/2 not just "small" ?

I have no idea, this was already there though.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/#review58778
-----------------------------------------------------------


On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118413/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a 
> 
> Diff: https://git.reviewboard.kde.org/r/118413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140530/6db49fc7/attachment.html>


More information about the Plasma-devel mailing list