Review Request 118413: Put the settings views in a ScrollView

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118413/#review58778
-----------------------------------------------------------

Ship it!



desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40897>

    is large/2 not just "small" ?



desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40896>

    remove this debug info



desktoppackage/contents/configuration/AppletConfiguration.qml
<https://git.reviewboard.kde.org/r/118413/#comment40898>

    I'm not 100% convinced by this, it means a text label won't wrap as that can have a huge implicitWidth.
    
    Lets only make it grow vertically.
    


- David Edmundson


On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118413/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 12:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a 
> 
> Diff: https://git.reviewboard.kde.org/r/118413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140530/8ffab38b/attachment-0001.html>