Review Request 118361: Don't hide Dialog when opening QMenu from it

[Martin Klapetek]

> On May 28, 2014, 12:38 a.m., David Edmundson wrote:
> > That's frickin' clever! 
> > We can remove a lot of hacks thanks to this.
> > 
> > Do we even need the last clause? Surely any child window shouldn't close the parent?

You mean the QMenuClassWindow part? It's a bit tricky opening a QMenu from QML popup (applet in a panel) because it's impossible to set any kind of parent on the menu window because the applet does not have access to the Dialog it's inside of and so cannot pass it to the menu.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58613
-----------------------------------------------------------


On May 27, 2014, 9:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118361/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 9:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When plasmoid in a popup is opening a QMenu, the popup itself hides because it looses focus. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp d8e263c 
> 
> Diff: https://git.reviewboard.kde.org/r/118361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/318a2c28/attachment.html>