Review Request 118361: Don't hide Dialog when opening QMenu from it

Marco Martin notmart at gmail.com
Wed May 28 08:55:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58624
-----------------------------------------------------------

Ship it!


not sure if is safe to assume to not close when any new focus window is a menu, but i think it's the way to go anyways

- Marco Martin


On May 27, 2014, 7:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118361/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 7:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When plasmoid in a popup is opening a QMenu, the popup itself hides because it looses focus. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp d8e263c 
> 
> Diff: https://git.reviewboard.kde.org/r/118361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/d68689e4/attachment.html>


More information about the Plasma-devel mailing list