Review Request 118275: Remove duplicated code in showEvent and constructor

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118275/#review58431
-----------------------------------------------------------


Looks good, but please test it thoroughly.

Note that everything called against the winId has to be re-called when setScreen is called because it might re-create the window.

- Aleix Pol Gonzalez


On May 23, 2014, 12:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118275/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove duplicated code in showEvent and constructor
> 
> Hiding a window doesn't delete it so we shouldn't have to set all these things again, but I'm not 100% confident enough to just push.
> 
> 
> Diffs
> -----
> 
>   shell/panelconfigview.cpp b3bf598 
> 
> Diff: https://git.reviewboard.kde.org/r/118275/diff/
> 
> 
> Testing
> -------
> 
> Looks the same to me, but I'm not entirely sure what the shadows and blur etc. look like so I might be missing something.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/c2b236e7/attachment.html>