Review Request 118275: Remove duplicated code in showEvent and constructor

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118275/#review58365
-----------------------------------------------------------


flags and type might be needed in the show event. I recommend to verify using xprop. The problem is that Qt doesn't "know" all window states and types and overwrites anything we might have set manually. So we need to re-update the properties after Qt showed the window (it's on my todo to teach Qt this).

Also the forceActiveWindow should not be needed. It's normally a sign that something is wrong. If it sets the proper transient hints, etc. etc. KWin will pass it focus. But in the case of the panel controller it might be needed as the panel doesn't accept focus.

- Martin Gräßlin


On May 23, 2014, 2:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118275/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 2:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Remove duplicated code in showEvent and constructor
> 
> Hiding a window doesn't delete it so we shouldn't have to set all these things again, but I'm not 100% confident enough to just push.
> 
> 
> Diffs
> -----
> 
>   shell/panelconfigview.cpp b3bf598 
> 
> Diff: https://git.reviewboard.kde.org/r/118275/diff/
> 
> 
> Testing
> -------
> 
> Looks the same to me, but I'm not entirely sure what the shadows and blur etc. look like so I might be missing something.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140523/a32f138d/attachment-0001.html>