Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

[Martin Klapetek]

> On May 23, 2014, 12:46 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 87-88
> > <https://git.reviewboard.kde.org/r/118274/diff/2/?file=274306#file274306line87>
> >
> >     So I'm thinking these 2 are unused now?

No, they still are. The sizehelper is used to determine the applet size in the layout; its pixelSize with the different fontSizeMode then serves as the font's max size, not the actual size. The actual size is computed and set by QML internally.

So if we now use the sizehelper's pixelSize, it's set to the max value, using the fontSizeMode makes sure it fits as it should.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118274/#review58347
-----------------------------------------------------------


On May 23, 2014, 12:36 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118274/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 12:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335147
>     https://bugs.kde.org/show_bug.cgi?id=335147
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> QML offers a fontSizeMode[1] setting that scales font to the available size. I've replaced the sizing timer we had in clock with this, works very well.
> 
> [1] http://qt-project.org/doc/qt-5/qml-qtquick-text.html#fontSizeMode-prop
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml c05711e 
> 
> Diff: https://git.reviewboard.kde.org/r/118274/diff/
> 
> 
> Testing
> -------
> 
> Plasmoid in horizontal panel - great
> Plasmoid in vertical panel - also great
> Plasmoid on desktop - perfect
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140523/5610e7c1/attachment.html>