Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118274/#review58347
-----------------------------------------------------------



applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/118274/#comment40598>

    So I'm thinking these 2 are unused now?


- David Edmundson


On May 23, 2014, 10:36 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118274/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 10:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335147
>     https://bugs.kde.org/show_bug.cgi?id=335147
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> QML offers a fontSizeMode[1] setting that scales font to the available size. I've replaced the sizing timer we had in clock with this, works very well.
> 
> [1] http://qt-project.org/doc/qt-5/qml-qtquick-text.html#fontSizeMode-prop
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml c05711e 
> 
> Diff: https://git.reviewboard.kde.org/r/118274/diff/
> 
> 
> Testing
> -------
> 
> Plasmoid in horizontal panel - great
> Plasmoid in vertical panel - also great
> Plasmoid on desktop - perfect
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140523/9e5eb3cd/attachment.html>