Review Request 118251: Small improvments to FadingNode and IconItem

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review58275
-----------------------------------------------------------



src/declarativeimports/core/fadingnode.cpp
<https://git.reviewboard.kde.org/r/118251/#comment40540>

    Now it will animate backwards?
    
    Unless you change the vertex shader too.



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/118251/#comment40539>

    Why?
    The pixmap hasn't been loaded yet. There's a plasma style timer, m_loadPixmapTimer


- David Edmundson


On May 22, 2014, 6:02 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118251/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 6:02 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Small improvments to FadingNode and IconItem
> 
> * trigger an update after the animation finished as the IconItem needs to
>   switch to SVGTextureNode again
> * Don't connect needlessly to a lambda slot
> * FadingMaterialShader had the texture bind swapped
> * Fix virtual method hidden warning in FadingMaterialShader
> * Use dynamic_cast instead of static_cast to convert to SVGTextureNode
>   or FadingNode.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/fadingnode.cpp 207eff3902848a3c76bf1ec62d73877d6d9d0df7 
>   src/declarativeimports/core/iconitem.cpp bdf5e286c9bff3ebd0b124f1593de63ed4232515 
> 
> Diff: https://git.reviewboard.kde.org/r/118251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140522/1f70ec12/attachment-0001.html>