Fwd: [kconfig] src/core: Store app config file in ~/.config/<domain>/<app>rc

[Martin Gräßlin]

On Monday 05 May 2014 08:17:49 David Faure wrote:
> On Monday 05 May 2014 07:25:37 Martin Gräßlin wrote:
> > On Sunday 04 May 2014 23:53:40 David Faure wrote:
> > > Hello,
> > > 
> > > please note this change in KConfig.
> > > 
> > > I would recommend making sure your applications call
> > > app.setOrganizationDomain("kde.org") so that the config files go into
> > > the
> > > right subdir right now. Otherwise you'll face migration issues later
> > > when
> > > setting that.
> > 
> > How does that affect setting configuration from a kcm? E.g. if loaded
> > through systemsettings one could assume that setOrganizationDomain is set
> > to "kde.org" which could break any kcm needing another organization
> > domain.
> > Or if a KCM sets this to foo.bar than any kcm not resetting to kde.org
> > would break, wouldn't it?
> 
> I doubt KCMs use KSharedConfig::openConfig() or KConfig() without arguments.
> That would lead to "kcmshell5rc" or "systemsettingsrc" right now.
> Instead they surely name the config file they want to edit.
> 
> If that config file happens to be for a specific application (rather than
> shared), then the KCM will need to open e.g. "kde.org/konquerorrc" instead
> of "konquerorrc", indeed.

Yes, that's what I mean. E.g. in KWin our kcms do:
KSharedConfig::openConfig("kwin");

while in KWin it might be possible that we do:
KSharedConfig::openConfig();

(though I think most use KSharedConfig::openConfig())

which would result in breakage if we forget to adjust one.

Thus it looks to me that we need to verify each and every KConfig and 
KSharedConfig::openConfig call and also kcfg files, right?

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140505/9c895ebe/attachment.sig>