Review Request 117101: This patch fixes font size behaviour when pmc is resized.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117101/#review54353
-----------------------------------------------------------


Doesn't really look on my box http://i.imgur.com/nJMYi9E.jpg
Also, I think the right fix for these things is to use one of PlasmaExtras.Heading, PlasmaExtras.Title (or PlasmaExtras.Paragraph when applicable). Can someone else comment on whether making the font depend on window size is a good idea?

- Shantanu Tushar


On March 26, 2014, 9:29 p.m., Nikolaos Chatzidakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117101/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 9:29 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 
>   mediaelements/mediawelcome/MediaWelcome.qml a3108d8 
> 
> Diff: https://git.reviewboard.kde.org/r/117101/diff/
> 
> 
> Testing
> -------
> 
> The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well.
> 
> 
> Thanks,
> 
> Nikolaos Chatzidakis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140327/59bf6e1e/attachment.html>