<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117101/">https://git.reviewboard.kde.org/r/117101/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't really look on my box http://i.imgur.com/nJMYi9E.jpg
Also, I think the right fix for these things is to use one of PlasmaExtras.Heading, PlasmaExtras.Title (or PlasmaExtras.Paragraph when applicable). Can someone else comment on whether making the font depend on window size is a good idea?</pre>
<br />
<p>- Shantanu Tushar</p>
<br />
<p>On March 26th, 2014, 9:29 p.m. UTC, Nikolaos Chatzidakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Shantanu Tushar.</div>
<div>By Nikolaos Chatzidakis.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 9:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/BackendsListDelegate.qml <span style="color: grey">(4840982)</span></li>
<li>mediaelements/mediawelcome/MediaWelcome.qml <span style="color: grey">(a3108d8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117101/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>