Review Request 116983: Fix the height of the buttonsbar

[Giorgos Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116983/
-----------------------------------------------------------

(Updated March 24, 2014, 12:26 p.m.)


Review request for Plasma.


Changes
-------

I have removed the margins because they were pushing the buttons away from the
background and also I don't think that they should exist.

I have attached another screenshot in which the buttons and the background align correctly.

Here the refreshButton has implicitHeight 26 and the background 52(tested with console.log)
but the background doesn't seem to have 52, its more like 26(see the image without_margins.png).


Repository: plasmate


Description
-------

If I am not mistaken a regression has been introduced in plasmoidviewer.
This patch solves the issue.


Diffs (updated)
-----

  plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 

Diff: https://git.reviewboard.kde.org/r/116983/diff/


Testing
-------

I have attached two images 1 without my patch and one with my patch


File Attachments (updated)
----------------

after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png
before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png
plasmoidviewer without margins
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140324/18034ecd/attachment.html>