Review Request 116983: Fix the height of the buttonsbar

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116983/#review53931
-----------------------------------------------------------


I don't understand why this happens. *2 makes sense to me, and it makes the bar have the right size to host the buttons, plus a bit of space. *4 made it way to big. Could you check again what the implicitHeight of a button is, and why on your system it apparently is smaller than the button itself?

- Sebastian Kügler


On March 22, 2014, 7:42 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116983/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 7:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> If I am not mistaken a regression has been introduced in plasmoidviewer.
> This patch solves the issue.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e35115805d3db5a8eaf24207dc386ed09c 
> 
> Diff: https://git.reviewboard.kde.org/r/116983/diff/
> 
> 
> Testing
> -------
> 
> I have attached two images 1 without my patch and one with my patch
> 
> 
> File Attachments
> ----------------
> 
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140324/1a6e6b1a/attachment-0001.html>