Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
Shantanu Tushar
shantanu at kde.org
Wed Mar 19 03:37:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116554/#review53384
-----------------------------------------------------------
shells/newshell/mainwindow.cpp
<https://git.reviewboard.kde.org/r/116554/#comment37550>
Why is this call to getMediaPlayer needed? Please check if just calling processCommandLineArgs(args) is enough. If so, update the diff.
- Shantanu Tushar
On March 18, 2014, 10 p.m., Harshit Agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116554/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 10 p.m.)
>
>
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Referring to Bug #331040 The functionality of the media starting to play on the press of the "Play All" button has been implemented.
> It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist.
>
>
> Diffs
> -----
>
> shells/newshell/package/contents/ui/mediacenter.qml bac33c2
> browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7
> shells/newshell/mainwindow.h f224060
> shells/newshell/mainwindow.cpp f721d68
>
> Diff: https://git.reviewboard.kde.org/r/116554/diff/
>
>
> Testing
> -------
>
> The testing has been done through various test scenarios.
>
>
> Thanks,
>
> Harshit Agarwal
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140319/dd0635fe/attachment.html>
More information about the Plasma-devel
mailing list