Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

Harshit Agarwal see.harshit at gmail.com
Tue Mar 18 22:00:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116554/
-----------------------------------------------------------

(Updated March 18, 2014, 10 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

removed the void MainWindow::playPlaylist() function, and introduced a slot to getMediaPlayer() in addNewInstanceArgsPlaylist().

Tested for playing a different file from the command line while PMC is open. Operating as expected.
Rest of the implementation working as planned.


Repository: plasma-mediacenter


Description
-------

Referring to Bug #331040 The functionality of the media starting to play on the press of the "Play All" button has been implemented.
It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. 


Diffs (updated)
-----

  shells/newshell/package/contents/ui/mediacenter.qml bac33c2 
  browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 
  shells/newshell/mainwindow.h f224060 
  shells/newshell/mainwindow.cpp f721d68 

Diff: https://git.reviewboard.kde.org/r/116554/diff/


Testing
-------

The testing has been done through various test scenarios.


Thanks,

Harshit Agarwal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140318/3913da89/attachment.html>


More information about the Plasma-devel mailing list