Review Request 116693: Improve layout of Effect View

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116693/#review52507
-----------------------------------------------------------

Ship it!



qml/Video.qml
<https://git.reviewboard.kde.org/r/116693/#comment37125>

    can this become:
    
    visible: videoItem.playbackState != MediaPlayer.StoppedState
    
    and then remove the one line in onClicked and the connection?



qml/Video.qml
<https://git.reviewboard.kde.org/r/116693/#comment37124>

    Long term this will get you in trouble, though I see it's just shifted from the old code. 
    
    I'm not sure what the correct way to get KStandardIconSizes is nor if they are exposed to QML anywhere.
    
    (Note: We don't want to use units as a solution, as it should match the user's set icon sizes for applications, not what plasma-shell is doing)


- David Edmundson


On March 10, 2014, 9:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116693/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 9:48 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, Thomas Pfeiffer, and Antonis Tsiapaliokas.
> 
> 
> Repository: kwin-compositing-kcm
> 
> 
> Description
> -------
> 
> Improve layout of Effect View
> 
> * use frame in the scroll area
> * remove needless anchoring for an Effect
> * use one RowLayout for one Effect row
> * add a left and right padding using the normal spacing
> * Use a ColumnLayout for the center element consisting of
>   ** name
>   ** description
>   ** (info)
>   ** (video)
> 
> 
> Diffs
> -----
> 
>   qml/Effect.qml 62ec89c83b02f14facd74eabaf4f4ba2cb0cab31 
>   qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 
>   qml/Video.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116693/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Effects View together with the QtQuick Controls text field
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/3dd02cd5-e489-45ae-a66a-92a62a4ef5e3__kwineffects.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/3ac65131/attachment.html>