Review Request 116693: Improve layout of Effect View

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116693/
-----------------------------------------------------------

Review request for kwin, Plasma, David Edmundson, Thomas Pfeiffer, and Antonis Tsiapaliokas.


Repository: kwin-compositing-kcm


Description
-------

Improve layout of Effect View

* use frame in the scroll area
* remove needless anchoring for an Effect
* use one RowLayout for one Effect row
* add a left and right padding using the normal spacing
* Use a ColumnLayout for the center element consisting of
  ** name
  ** description
  ** (info)
  ** (video)


Diffs
-----

  qml/Effect.qml 62ec89c83b02f14facd74eabaf4f4ba2cb0cab31 
  qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 
  qml/Video.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116693/diff/


Testing
-------


File Attachments
----------------

Effects View together with the QtQuick Controls text field
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/3dd02cd5-e489-45ae-a66a-92a62a4ef5e3__kwineffects.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/f04ddfca/attachment-0001.html>