Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

[Thomas Pfeiffer]

> On March 9, 2014, 6:04 p.m., Thomas Lübking wrote:
> > File Attachment: New advanced compositing KCM - kcmcompositing.png
> > <https://git.reviewboard.kde.org/r/116648/#fcomment175>
> >
> >     OOC: Is there any HIG on this?
> >     Is the situation on QML better than on QWidget?
> >     (The issue is that the label is not active what makes the checkbox hitarea smaller than usual)
> >     
> >     I do this as well since QFormLayout somehow "enforces" it, yet it's anything but ideal :-(
> >     
> >     The second issue with this is that the -pot. very long- label is put on the left (it's worse with fullscreen unredirection) what makes either side vertically unbalanced.
> >     
> >     Maybe split the labels?
> >     
> >     Startup: [ ] Enable desktop effects
> >     Fullscreen window: [ ] Exclude from desktop effects
> >     Color correction: [ ] Enabled (experimental)
> 
> Martin Gräßlin wrote:
>     HIG is at http://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment#Checkboxes
>     
>     And given that it doesn't follow the HIG. For the record: it was the least worst layout, I tried normal vbox layout and a table layout with spanning before. I'll give a try at improving it by grouping the checkboxes a little bit better.
> 
> Martin Gräßlin wrote:
>     New screenshot: http://paste.opensuse.org/84257207
>     
>     I like that quite a bit, we only need a label for this top group and I'm lacking ideas for it :-)

Thank you Thomas for pointing that out, and shame on me for missing it. This indeed has to be fixed. We could either just put all the checkboxes at the bottom and to the left (this has the downside that the "overall switch" is not at the top anymore, though), or we could use a super generic label such as "Options". Depending o the definition, one could of course argue that all of these are options, but "option" might be more closely associated with binary choices than others.
Admittedly, none of these are exactly perfect, but decoupling label and checkbox is simply not something we want, and for a settings dialog, ease of use is more important than aesthetics.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116648/#review52461
-----------------------------------------------------------


On March 9, 2014, 1:53 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116648/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 1:53 p.m.)
> 
> 
> Review request for kwin, Plasma and Antonis Tsiapaliokas.
> 
> 
> Repository: kwin-compositing-kcm
> 
> 
> Description
> -------
> 
> Split into one KCM for Desktop Effects and one for Compositing
> 
> Let's try getting the KCM a little bit less scary by properly
> hiding everything the user doesn't have to care about. The prominent
> desktop effects KCM only contains the list of all the effects which
> can be configured and nothing else. Only exception is the disabled
> check after failed GL to make this easier for the user.
> 
> All the "advanced" settings are moved into a new KCM called
> "Compositing" which is put under the hardware component in
> systemsettings. This contains all advanced settings including
> * whether compositing is enabled at all
> * backend
> * animation speeed
> * scale filter
> * unredirect fullscreen
> * color correction
> 
> 
> Diffs
> -----
> 
>   qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3 
>   qml/OpenGLErrorView.qml PRE-CREATION 
>   qml/main-compositing.qml PRE-CREATION 
>   qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 
>   qml/CompositingView.qml PRE-CREATION 
>   model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6 
>   model.h 2efa2a9df63ee7f7ec483df004ff9530fdc0f852 
>   main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946 
>   kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a 
>   kcmkwineffects.desktop PRE-CREATION 
>   CMakeLists.txt d70672f3937fb44240c2c2d8e2a8d90c67890e2a 
> 
> Diff: https://git.reviewboard.kde.org/r/116648/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New advanced compositing KCM
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png
> New effects KCM
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png
> Effects KCM with GHNS button
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140310/2c2fd134/attachment-0001.html>