<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116648/">https://git.reviewboard.kde.org/r/116648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2014, 6:04 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116648/file/1100/" style="color: black; font-weight: bold; font-size: 9pt;">kcmcompositing.png</a>
<p>New advanced compositing KCM</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OOC: Is there any HIG on this?
Is the situation on QML better than on QWidget?
(The issue is that the label is not active what makes the checkbox hitarea smaller than usual)
I do this as well since QFormLayout somehow "enforces" it, yet it's anything but ideal :-(
The second issue with this is that the -pot. very long- label is put on the left (it's worse with fullscreen unredirection) what makes either side vertically unbalanced.
Maybe split the labels?
Startup: [ ] Enable desktop effects
Fullscreen window: [ ] Exclude from desktop effects
Color correction: [ ] Enabled (experimental)</pre>
</blockquote>
<p>On March 10th, 2014, 7:49 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">HIG is at http://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment#Checkboxes
And given that it doesn't follow the HIG. For the record: it was the least worst layout, I tried normal vbox layout and a table layout with spanning before. I'll give a try at improving it by grouping the checkboxes a little bit better.</pre>
</blockquote>
<p>On March 10th, 2014, 7:57 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New screenshot: http://paste.opensuse.org/84257207
I like that quite a bit, we only need a label for this top group and I'm lacking ideas for it :-)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you Thomas for pointing that out, and shame on me for missing it. This indeed has to be fixed. We could either just put all the checkboxes at the bottom and to the left (this has the downside that the "overall switch" is not at the top anymore, though), or we could use a super generic label such as "Options". Depending o the definition, one could of course argue that all of these are options, but "option" might be more closely associated with binary choices than others.
Admittedly, none of these are exactly perfect, but decoupling label and checkbox is simply not something we want, and for a settings dialog, ease of use is more important than aesthetics.
</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 9th, 2014, 1:53 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin, Plasma and Antonis Tsiapaliokas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 9, 2014, 1:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin-compositing-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split into one KCM for Desktop Effects and one for Compositing
Let's try getting the KCM a little bit less scary by properly
hiding everything the user doesn't have to care about. The prominent
desktop effects KCM only contains the list of all the effects which
can be configured and nothing else. Only exception is the disabled
check after failed GL to make this easier for the user.
All the "advanced" settings are moved into a new KCM called
"Compositing" which is put under the hardware component in
systemsettings. This contains all advanced settings including
* whether compositing is enabled at all
* backend
* animation speeed
* scale filter
* unredirect fullscreen
* color correction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>qml/main.qml <span style="color: grey">(d22dd08da529df938d99ff9d43f52f7b33a7f2d3)</span></li>
<li>qml/OpenGLErrorView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/main-compositing.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>qml/EffectView.qml <span style="color: grey">(c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2)</span></li>
<li>qml/CompositingView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>model.cpp <span style="color: grey">(2b25fe04ccacf0fb719956b1b5fa0267611747e6)</span></li>
<li>model.h <span style="color: grey">(2efa2a9df63ee7f7ec483df004ff9530fdc0f852)</span></li>
<li>main.cpp <span style="color: grey">(5c68722961be9b8a0a48f3221df7c033ba3cf946)</span></li>
<li>kwincompositing.desktop <span style="color: grey">(88ecf46b393df947d6b59ce53c924a82fc65756a)</span></li>
<li>kcmkwineffects.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d70672f3937fb44240c2c2d8e2a8d90c67890e2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116648/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png">New advanced compositing KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png">New effects KCM</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png">Effects KCM with GHNS button</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>