Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

Ashish Madeti ashishmadeti at gmail.com
Tue Mar 4 19:28:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
-----------------------------------------------------------

(Updated March 4, 2014, 7:28 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

The previous patch made the view to scroll like "crazy" (as pointed out by Shantanu) when mouse pointer reached somewhat near the end of the view.
Fixed by making a little change to Playlist.qml


Repository: plasma-mediacenter


Description
-------

Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to navigate the playlist then before.


Diffs (updated)
-----

  mediaelements/playlist/Playlist.qml fd83c21 
  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
-------

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140304/2288430b/attachment.html>


More information about the Plasma-devel mailing list