Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review51911
-----------------------------------------------------------


Thanks for the patch, this does fix it to the expected behavior. However, if you move your mouse pointer to items near the end of the view, it starts to scroll like crazy. You might want to look at Playlist.qml line 130 and see if you can make this better.

- Shantanu Tushar


On March 4, 2014, 3:17 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 3:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Before this patch it was not possible to delete media (only using mouse) from a playlist without playing the media, as reported in Bug 329168 : https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to navigate the playlist then before.
> 
> 
> Diffs
> -----
> 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> -------
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140304/9670837b/attachment-0001.html>