Review Request 114429: use of time data engine -> less code

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114429/#review51754
-----------------------------------------------------------


The interval needs changing, otherwise, this is the correct solution for the problem others have been trying to solve.


mediaelements/mediawelcome/HomeScreenFooter.qml
<https://git.reviewboard.kde.org/r/114429/#comment36826>

    This is updating too often, if we don't show seconds, we don't need to wake up every half-a-second


- Sebastian Kügler


On Feb. 11, 2014, 12:01 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114429/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 12:01 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Bugs: 330115
>     http://bugs.kde.org/show_bug.cgi?id=330115
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Replaced Text{} by Label {}
> Time Data engine instead of creating Date() and hours -> less code !
> text color is predefined in Label {} 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
> 
> Diff: https://git.reviewboard.kde.org/r/114429/diff/
> 
> 
> Testing
> -------
> 
> yeah ,works fine ,displays days as well now.
> 
> 
> File Attachments
> ----------------
> 
> screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/dfae9d60-ef6f-4562-a7e3-8f6c0d97a99e__pmc1.png
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140303/3e2d0e65/attachment-0001.html>