Review Request 114429: use of time data engine -> less code
Shantanu Tushar
shantanu at kde.org
Sat Mar 1 13:49:33 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114429/#review51432
-----------------------------------------------------------
Ship it!
This can go in with the date part removed (time only). Please feel free to push with that change.
- Shantanu Tushar
On Feb. 11, 2014, 12:01 p.m., Heena Mahour wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114429/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 12:01 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Bugs: 330115
> http://bugs.kde.org/show_bug.cgi?id=330115
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Replaced Text{} by Label {}
> Time Data engine instead of creating Date() and hours -> less code !
> text color is predefined in Label {}
>
>
> Diffs
> -----
>
> mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
> mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
>
> Diff: https://git.reviewboard.kde.org/r/114429/diff/
>
>
> Testing
> -------
>
> yeah ,works fine ,displays days as well now.
>
>
> File Attachments
> ----------------
>
> screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/dfae9d60-ef6f-4562-a7e3-8f6c0d97a99e__pmc1.png
>
>
> Thanks,
>
> Heena Mahour
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140301/1288acb7/attachment-0001.html>
More information about the Plasma-devel
mailing list