Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

Harshit Agarwal see.harshit at gmail.com
Mon Mar 3 09:29:39 UTC 2014



> On March 3, 2014, 6:01 a.m., Sujith Haridasan wrote:
> > Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the "Play All" starts working as per my observation. Let me know if I am wrong.

Test Cases:
1. With an pre-empty playlist, added videos from a folder on the local drive. Result: The videos get added on clicking the "PlayAll" Button, and the first video starts playing, window remains in the file browser only.
2. With a pre-filled playlist, and some video playing from the playlist, went to another folder and clicked "PlayAll" to a new set of videos. They get added to the existing playlist and the video continues without breaking.
3. With a single video playing from the local drive, and an empty playlist before, clicked "PlayAll" on a list of videos from a folder. They get added to the playlist, but do not disturb the current video playing. 


- Harshit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116554/#review51736
-----------------------------------------------------------


On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116554/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 10:53 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Referring to Bug #331040 The functionality of the media starting to play on the press of the "Play All" button has been implemented.
> It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. 
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 
> 
> Diff: https://git.reviewboard.kde.org/r/116554/diff/
> 
> 
> Testing
> -------
> 
> The testing has been done through various test scenarios.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140303/1d9bca37/attachment.html>


More information about the Plasma-devel mailing list