<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116554/">https://git.reviewboard.kde.org/r/116554/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2014, 6:01 a.m. UTC, <b>Sujith Haridasan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the "Play All" starts working as per my observation. Let me know if I am wrong.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test Cases:
1. With an pre-empty playlist, added videos from a folder on the local drive. Result: The videos get added on clicking the "PlayAll" Button, and the first video starts playing, window remains in the file browser only.
2. With a pre-filled playlist, and some video playing from the playlist, went to another folder and clicked "PlayAll" to a new set of videos. They get added to the existing playlist and the video continues without breaking.
3. With a single video playing from the local drive, and an empty playlist before, clicked "PlayAll" on a list of videos from a folder. They get added to the playlist, but do not disturb the current video playing. </pre>
<br />
<p>- Harshit</p>
<br />
<p>On March 2nd, 2014, 10:53 p.m. UTC, Harshit Agarwal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.</div>
<div>By Harshit Agarwal.</div>
<p style="color: grey;"><i>Updated March 2, 2014, 10:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Referring to Bug #331040 The functionality of the media starting to play on the press of the "Play All" button has been implemented.
It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The testing has been done through various test scenarios.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: grey">(faaafa7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>