Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118886/#review60735
-----------------------------------------------------------


(Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?)

My rule in these cases is to copy Qt :)
QQuickText uses QRectF so it's fine. 


src/declarativeimports/core/windowthumbnail.h
<https://git.reviewboard.kde.org/r/118886/#comment42330>

    I would just have the one signal, paintedSizeChanged.
    
    Otherwise we potentially end up re-evaluating loads of bindings twice.
    (Qt does this for the Text item)



src/declarativeimports/core/windowthumbnail.cpp
<https://git.reviewboard.kde.org/r/118886/#comment42329>

    Should this and m_paintedSize be QRectFs?
    
    We're using reals everywhere, and more importantly using QRectF for the node->setRect()
    
    


- David Edmundson


On June 22, 2014, 7:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118886/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 7:54 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately.
> 
> (Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.h 14fc44a 
>   src/declarativeimports/core/windowthumbnail.cpp b10f030 
> 
> Diff: https://git.reviewboard.kde.org/r/118886/diff/
> 
> 
> Testing
> -------
> 
> Works, reports the actual size
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140622/ef51d231/attachment-0001.html>