Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail

Kai Uwe Broulik kde at privat.broulik.de
Sun Jun 22 19:54:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118886/
-----------------------------------------------------------

Review request for Plasma and Martin Gräßlin.


Repository: plasma-framework


Description
-------

This adds paintedWidth and paintedHeight properties to PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is scaled keeping aspect ratio, actually is, similar to what QML Image does. This is will eventually allow the taskmanager to size its tooltips more appropriately.

(Is it better to store m_paintedWidth and m_paintedHeight separately, or is the QSize thing I used ok?)


Diffs
-----

  src/declarativeimports/core/windowthumbnail.h 14fc44a 
  src/declarativeimports/core/windowthumbnail.cpp b10f030 

Diff: https://git.reviewboard.kde.org/r/118886/diff/


Testing
-------

Works, reports the actual size


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140622/746fae37/attachment.html>


More information about the Plasma-devel mailing list