Review Request 118876: Remove start in systemtray option from the kmenuedit.

[Eike Hein]

> On June 22, 2014, 12:29 p.m., Eike Hein wrote:
> > Additionally, note that the "Place in system tray" option is also in frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general .desktop app link properties UI (the one that also used to be loaded by the config dialog for Icon applets before we lost that due to the Qt Quick Controls switch).
> 
> Bhushan Shah wrote:
>     Or maybe we can make this option do nothing for now.. and revisit this once someone ports ksystraycmd to sni? I opened this review because one of user at #plasma reported autostart apps not starting due to this thing.

We could, but people might also have existing custom menu entry .desktop files relying on ksystraycmd working, so while turning the option into a no-op would prevent broken entries from being created it wouldn't fully solve the problem (nor would removing the option actually).

The problem of course is that this is a case that can't be fully addressed by keeping the KDE 4 version around as a fallback either, since the tray applet no longer supports KSystemTrayIcon.

Seems to me the only real fix is to port ksystraycmd indeed ...


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118876/#review60696
-----------------------------------------------------------


On June 22, 2014, 12:17 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118876/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 12:17 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: kmenuedit
> 
> 
> Description
> -------
> 
> This option uses ksystraycmd tool which is removed long ago
> 
> http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7
> 
> 
> Diffs
> -----
> 
>   basictab.h 9aa4c18 
>   basictab.cpp 6e3e086 
> 
> Diff: https://git.reviewboard.kde.org/r/118876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140622/dac42748/attachment.html>