<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118876/">https://git.reviewboard.kde.org/r/118876/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 22nd, 2014, 12:29 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Additionally, note that the "Place in system tray" option is also in frameworks/kio/src/widgets/kpropertiesdesktopadvbase.ui for the general .desktop app link properties UI (the one that also used to be loaded by the config dialog for Icon applets before we lost that due to the Qt Quick Controls switch).</pre>
</blockquote>
<p>On June 22nd, 2014, 12:33 p.m. UTC, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Or maybe we can make this option do nothing for now.. and revisit this once someone ports ksystraycmd to sni? I opened this review because one of user at #plasma reported autostart apps not starting due to this thing.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We could, but people might also have existing custom menu entry .desktop files relying on ksystraycmd working, so while turning the option into a no-op would prevent broken entries from being created it wouldn't fully solve the problem (nor would removing the option actually).
The problem of course is that this is a case that can't be fully addressed by keeping the KDE 4 version around as a fallback either, since the tray applet no longer supports KSystemTrayIcon.
Seems to me the only real fix is to port ksystraycmd indeed ...</pre>
<br />
<p>- Eike</p>
<br />
<p>On June 22nd, 2014, 12:17 p.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Àlex Fiestas.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated June 22, 2014, 12:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmenuedit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This option uses ksystraycmd tool which is removed long ago
http://commits.kde.org/kde-workspace/38fddebe00a271436c17120a0adffeb0f52a1af7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>basictab.h <span style="color: grey">(9aa4c18)</span></li>
<li>basictab.cpp <span style="color: grey">(6e3e086)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>