Review Request 118840: kde-baseapps frameworks dolphin with snapshot frameworks branch baloo/baloo-widgets path fixes.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118840/#review60537
-----------------------------------------------------------

Ship it!


Thanks for the patch! I could not reproduce the build failure - maybe I still had some old files in my install directory that made it work.

I can confirm that the build also works with your patch though, and it looks OK (if anyone who is more familiar with the KF5 headers than me, please speak up!).

Please note that there is a 'dolphin' group, which you should use for future review requests. This is much better than adding myself to the 'People' field because more people will notice your patches then and may be able to provide useful feedback.

- Frank Reininghaus


On June 19, 2014, 3:26 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118840/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 3:26 p.m.)
> 
> 
> Review request for Plasma, Frank Reininghaus and Jonathan Riddell.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> (frameworks branch) Dolphin would not compile against snapshot frameworks baloo and baloo-widgets. This fixes it, please let me know if there was a better way, i am still relatively new at this.
> Scarlett
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp acb3e0f 
>   dolphin/src/CMakeLists.txt 767cf7f 
>   dolphin/src/kitemviews/private/kbaloorolesprovider.cpp c0ae0c5 
>   dolphin/src/panels/places/placesitemmodel.cpp 6ba91c5 
>   dolphin/src/search/dolphinfacetswidget.h 757dcd4 
>   dolphin/src/search/dolphinsearchbox.cpp df96f74 
>   dolphin/src/settings/additionalinfodialog.cpp db9258a 
>   dolphin/src/views/dolphinview.cpp 0e43dcd 
>   dolphin/src/views/dolphinviewactionhandler.cpp 3955f25 
> 
> Diff: https://git.reviewboard.kde.org/r/118840/diff/
> 
> 
> Testing
> -------
> 
> Build in Kubuntu utopic was fine.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/05f159c9/attachment-0001.html>