<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118840/">https://git.reviewboard.kde.org/r/118840/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! I could not reproduce the build failure - maybe I still had some old files in my install directory that made it work.
I can confirm that the build also works with your patch though, and it looks OK (if anyone who is more familiar with the KF5 headers than me, please speak up!).
Please note that there is a 'dolphin' group, which you should use for future review requests. This is much better than adding myself to the 'People' field because more people will notice your patches then and may be able to provide useful feedback.</pre>
<br />
<p>- Frank Reininghaus</p>
<br />
<p>On June 19th, 2014, 3:26 p.m. UTC, Scarlett Clark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Frank Reininghaus and Jonathan Riddell.</div>
<div>By Scarlett Clark.</div>
<p style="color: grey;"><i>Updated June 19, 2014, 3:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(frameworks branch) Dolphin would not compile against snapshot frameworks baloo and baloo-widgets. This fixes it, please let me know if there was a better way, i am still relatively new at this.
Scarlett</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build in Kubuntu utopic was fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp <span style="color: grey">(acb3e0f)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(767cf7f)</span></li>
<li>dolphin/src/kitemviews/private/kbaloorolesprovider.cpp <span style="color: grey">(c0ae0c5)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: grey">(6ba91c5)</span></li>
<li>dolphin/src/search/dolphinfacetswidget.h <span style="color: grey">(757dcd4)</span></li>
<li>dolphin/src/search/dolphinsearchbox.cpp <span style="color: grey">(df96f74)</span></li>
<li>dolphin/src/settings/additionalinfodialog.cpp <span style="color: grey">(db9258a)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(0e43dcd)</span></li>
<li>dolphin/src/views/dolphinviewactionhandler.cpp <span style="color: grey">(3955f25)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118840/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>