Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

[Martin Gräßlin]

> On June 18, 2014, 2:54 p.m., David Edmundson wrote:
> > Are you not working on a patch to test at startup?
> >
> 
> Martin Gräßlin wrote:
>     yes I am, but this is orthogonal as it is in the frameworks.
> 
> David Edmundson wrote:
>     Good point.
>     
>     I think maybe I should patch Qt too. Currently a compile error in QSGMaterialShader is not fatal, QSimpleMaterialShader is. Thoughts?

yeah, I think a failing shader should never be fatal. Personally I think it would be best if Qt checks whether Shaders work early and not do anything in the whole scene graph.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118813/#review60394
-----------------------------------------------------------


On June 18, 2014, 2:19 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118813/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336272
>     http://bugs.kde.org/show_bug.cgi?id=336272
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie
> 
> Without GLSL our shader doesn't compile and Qt aborts when accessing the
> uniforms. We don't want that, abort is never nice.
> 
> BUG: 336272
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/fadingnode.cpp 0c41ec1f4cc2fe78af59dfb1c705bbc65697380b 
> 
> Diff: https://git.reviewboard.kde.org/r/118813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/2a99ce76/attachment-0001.html>