Review Request 118636: Reinstate login & logout sounds
David Edmundson
david at davidedmundson.co.uk
Fri Jun 13 15:12:31 UTC 2014
> On June 10, 2014, 1:15 p.m., David Edmundson wrote:
> > ksmserver/shutdown.cpp, line 501
> > <https://git.reviewboard.kde.org/r/118636/diff/1/?file=279977#file279977line501>
> >
> > Why do we have this if? What other state might we be in?
>
> Martin Klapetek wrote:
> This is the original code that was removed; maybe you can cancel the shutdown during the sound and so to prevent killing everything after the sound finishes (and logout is cancelled)?
Ah, I assume the logic is:
start shutdown
start playing sound
cancel somehow
if the sound ends you don't want to then shut down.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118636/#review59691
-----------------------------------------------------------
On June 10, 2014, 1:05 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118636/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 1:05 p.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Bugs: 335948
> https://bugs.kde.org/show_bug.cgi?id=335948
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This returns the feature of having and configuring login/logout sounds for workspace; default remains off for both.
>
> Additionally to this, I've made KNotification close immediately if there are no actions defined for the given event, so it won't even try (and wait for) all the notify plugins.
>
>
> Diffs
> -----
>
> ksmserver/CMakeLists.txt 71ad4fc
> ksmserver/plasma_workspace.notifyrc PRE-CREATION
> ksmserver/server.h f813394
> ksmserver/shutdown.cpp 6a6dca9
> ksmserver/startup.cpp 6f5d502
>
> Diff: https://git.reviewboard.kde.org/r/118636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140613/bbfad1b9/attachment.html>
More information about the Plasma-devel
mailing list