Review Request 118636: Reinstate login & logout sounds

[Martin Klapetek]

> On June 10, 2014, 3:15 p.m., David Edmundson wrote:
> > ksmserver/shutdown.cpp, line 468
> > <https://git.reviewboard.kde.org/r/118636/diff/1/?file=279977#file279977line468>
> >
> >     and if there is no sound the closed signal happens immediately?

If you mean no configured sound, then yes. It doesn't check for system actually having sound.


> On June 10, 2014, 3:15 p.m., David Edmundson wrote:
> > ksmserver/shutdown.cpp, line 501
> > <https://git.reviewboard.kde.org/r/118636/diff/1/?file=279977#file279977line501>
> >
> >     Why do we have this if? What other state might we be in?

This is the original code that was removed; maybe you can cancel the shutdown during the sound and so to prevent killing everything after the sound finishes (and logout is cancelled)?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118636/#review59691
-----------------------------------------------------------


On June 10, 2014, 3:05 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118636/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 3:05 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Bugs: 335948
>     https://bugs.kde.org/show_bug.cgi?id=335948
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This returns the feature of having and configuring login/logout sounds for workspace; default remains off for both.
> 
> Additionally to this, I've made KNotification close immediately if there are no actions defined for the given event, so it won't even try (and wait for) all the notify plugins.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 71ad4fc 
>   ksmserver/plasma_workspace.notifyrc PRE-CREATION 
>   ksmserver/server.h f813394 
>   ksmserver/shutdown.cpp 6a6dca9 
>   ksmserver/startup.cpp 6f5d502 
> 
> Diff: https://git.reviewboard.kde.org/r/118636/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140610/e05f48fb/attachment.html>